Remove unsafe in espressocrypto #380
Merged
+327
−819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImJeremyHe
requested review from
alysiahuggins,
zacshowa,
Sneh1999,
sveitser and
jbearer
as code owners
ImJeremyHe
force-pushed
the
jh/issue339
branch
6 times, most recently
from
a72471b to
1f55180
Compare
ImJeremyHe
force-pushed
the
jh/issue339
branch
from
1f55180 to
1297993
Compare
This will increase performance
ImJeremyHe
force-pushed
the
jh/issue339
branch
from
1297993 to
905ee28
Compare
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin celestia-integration
git worktree add -d .worktree/backport-380-to-celestia-integration origin/celestia-integration
cd .worktree/backport-380-to-celestia-integration
git switch --create backport-380-to-celestia-integration
git cherry-pick -x df1848b17eaa8c13a81da7b368dc749bdd2eccac 53ab629713f9db6057ecb8e60471bae886935ff1 905ee28af9c67a5417d014df69c2e5a8876e4453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #339
This PR includes:
Removal of
unsafein Espresso CryptoReplaced all unsafe code to ensure better safety and maintainability.
Updated Go Client with New API for Retrieving Raw Headers
Integrated the latest API, which allows direct access to raw headers.
Enhanced Performance by Eliminating Header Marshaling
Leveraged the new API to avoid redundant header marshaling, improving efficiency. As a result, the Go client no longer needs to support marshaling headers.